Skip to content

Update introductory examples.#52

Open
wes-smith wants to merge 3 commits into
mainfrom
grammar-wording-formatting-edits
Open

Update introductory examples.#52
wes-smith wants to merge 3 commits into
mainfrom
grammar-wording-formatting-edits

Conversation

@wes-smith

@wes-smith wes-smith commented May 4, 2026

Copy link
Copy Markdown
Collaborator

This PR reorders, modernizes, and polishes the introductory examples in the specification. It also contains a few small wording, grammar, and formatting updates.

Fixes #49.


Preview | Diff

@TallTed

TallTed commented May 5, 2026

Copy link
Copy Markdown
Member

If possible, better going forward to do section reordering (which show all lines as changed) in a distinct PR from content edits (which should only show the actually edited lines as changed).

@iherman

iherman commented May 5, 2026

Copy link
Copy Markdown
Member

The empoyment example seems to be clear. The card contains an MRZ with some data; we use that data, we create a VC referring back to the MRZ data and we create a QR that is put additionally to the MRZ. So that is fine.

But the driving license example is unclear: what do I see on figure 3? Is this the PDF417 barcode before augmentation or after? The introductory text (in the other PR) says that we "augment" a barcode, but what does it mean in practice for a driving license?

Is it so that, by some regulation that is not mentioned here, the PDF417 should contain some specific data if it was used without a credential? And what we do is we augment this virtual bar code with our process and we, sort of, replace the virtual PDF417?

@wes-smith wes-smith mentioned this pull request Jun 1, 2026
@iherman

iherman commented Jun 8, 2026

Copy link
Copy Markdown
Member

See my comments in #37 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The introductory examples may need some care...

3 participants